Utils/PathHelper: split normalize_path() method
#343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... into a `normalize_absolute_path()` and a `normalize_relative_path()` method. Linux paths are expected to start with a leading slash and functions like `file_exists()` will not work correctly without it. So... leading slashes should not be removed from absolute paths, but should be removed from relative paths (to allow for easy concatenation). Splitting the method and using the appropriate version in all the right places should fix this. Includes updated the tests. Includes updating function calls to the method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... into a
normalize_absolute_path()and anormalize_relative_path()method.Linux paths are expected to start with a leading slash and functions like
file_exists()will not work correctly without it. So... leading slashes should not be removed from absolute paths, but should be removed from relative paths (to allow for easy concatenation).Splitting the method and using the appropriate version in all the right places should fix this.
Includes updated the tests.
Includes updating function calls to the method.