Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stemmer/fr: restored & completed carry.js from original publication #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drzraf
Copy link

@drzraf drzraf commented Oct 15, 2017

raw from the PDF

  • step 3 was completed
  • tweaks were automatically removed
    Maybe another way to add them in a non-confusing way could be found? (custom "talisman" step?)

@Yomguithereal
Copy link
Owner

Yomguithereal commented Oct 15, 2017

Hello @drzraf. Thanks for your PR. Love you script to convert from the PDF to the rules :).

If I remember correctly, I think I avoided the STEP3 rules after some ones because I thought (probably wrongly it seems) that they were an erroneous repetition of some earlier rules. For instance (m > 0) issaient ε is also in STEP1 but I never thought this could be useful to re-run them.

Did it fix your issue with the word tristesse by the way? Can you add some unit tests to reflect the new cases taken into account please (it also seems that some test cases are now broken)?

Concerning my edits, I will add another version side by side which will be called revisited or whatever.

Thanks

@drzraf
Copy link
Author

drzraf commented Oct 16, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants