Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(consensus): Build Sprout and Sapling parameters into the zebrad binary, so a download server isn't needed #7800

Merged
merged 13 commits into from
Oct 24, 2023

Fix outdated timeout comments and short timeouts

dc58532
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

change(consensus): Build Sprout and Sapling parameters into the zebrad binary, so a download server isn't needed #7800

Fix outdated timeout comments and short timeouts
dc58532
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / actionlint succeeded Oct 24, 2023 in 0s

reviewdog [actionlint] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (48)

.github/workflows/cd-deploy-nodes-gcp.yml|219 col 9| shellcheck reported issue in this script: SC2086:info:1:165: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/cd-deploy-nodes-gcp.yml|219 col 9| shellcheck reported issue in this script: SC2086:info:12:61: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/cd-deploy-nodes-gcp.yml|219 col 9| shellcheck reported issue in this script: SC2086:info:12:125: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/cd-deploy-nodes-gcp.yml|219 col 9| shellcheck reported issue in this script: SC2086:info:13:107: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/cd-deploy-nodes-gcp.yml|219 col 9| shellcheck reported issue in this script: SC2086:info:18:46: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/cd-deploy-nodes-gcp.yml|320 col 9| shellcheck reported issue in this script: SC2086:info:12:61: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/cd-deploy-nodes-gcp.yml|320 col 9| shellcheck reported issue in this script: SC2086:info:12:125: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/cd-deploy-nodes-gcp.yml|320 col 9| shellcheck reported issue in this script: SC2086:info:13:107: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/cd-deploy-nodes-gcp.yml|320 col 9| shellcheck reported issue in this script: SC2086:info:17:44: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/chore-delete-gcp-resources.yml|58 col 9| shellcheck reported issue in this script: SC2086:info:10:52: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/chore-delete-gcp-resources.yml|91 col 9| shellcheck reported issue in this script: SC2086:info:11:48: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/chore-delete-gcp-resources.yml|91 col 9| shellcheck reported issue in this script: SC2086:info:23:48: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-build-crates.patch.yml|44 col 9| shellcheck reported issue in this script: SC2005:style:2:6: Useless echo? Instead of 'echo $(cmd)', just use 'cmd' [shellcheck]
.github/workflows/ci-build-crates.patch.yml|44 col 9| shellcheck reported issue in this script: SC2086:info:2:179: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-build-crates.patch.yml|44 col 9| shellcheck reported issue in this script: SC2005:style:5:8: Useless echo? Instead of 'echo $(cmd)', just use 'cmd' [shellcheck]
.github/workflows/ci-build-crates.patch.yml|44 col 9| shellcheck reported issue in this script: SC2086:info:5:15: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-build-crates.patch.yml|44 col 9| shellcheck reported issue in this script: SC2086:info:8:6: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-build-crates.patch.yml|44 col 9| shellcheck reported issue in this script: SC2086:info:9:6: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-build-crates.yml|72 col 9| shellcheck reported issue in this script: SC2005:style:2:6: Useless echo? Instead of 'echo $(cmd)', just use 'cmd' [shellcheck]
.github/workflows/ci-build-crates.yml|72 col 9| shellcheck reported issue in this script: SC2086:info:2:179: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-build-crates.yml|72 col 9| shellcheck reported issue in this script: SC2005:style:5:8: Useless echo? Instead of 'echo $(cmd)', just use 'cmd' [shellcheck]
.github/workflows/ci-build-crates.yml|72 col 9| shellcheck reported issue in this script: SC2086:info:5:15: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-build-crates.yml|72 col 9| shellcheck reported issue in this script: SC2086:info:8:6: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-build-crates.yml|72 col 9| shellcheck reported issue in this script: SC2086:info:9:6: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-coverage.yml|61 col 14| label "ubuntu-latest-xl" is unknown. available labels are "windows-latest", "windows-2022", "windows-2019", "windows-2016", "ubuntu-latest", "ubuntu-22.04", "ubuntu-20.04", "ubuntu-18.04", "macos-latest", "macos-latest-xl", "macos-13-xl", "macos-13", "macos-13.0", "macos-12-xl", "macos-12", "macos-12.0", "macos-11", "macos-11.0", "macos-10.15", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
.github/workflows/ci-coverage.yml|79 col 9| shellcheck reported issue in this script: SC2086:info:1:38: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-coverage.yml|87 col 9| shellcheck reported issue in this script: SC2086:info:1:28: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-coverage.yml|87 col 9| shellcheck reported issue in this script: SC2086:info:2:39: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-unit-tests-docker.yml|102 col 14| label "ubuntu-latest-xl" is unknown. available labels are "windows-latest", "windows-2022", "windows-2019", "windows-2016", "ubuntu-latest", "ubuntu-22.04", "ubuntu-20.04", "ubuntu-18.04", "macos-latest", "macos-latest-xl", "macos-13-xl", "macos-13", "macos-13.0", "macos-12-xl", "macos-12", "macos-12.0", "macos-11", "macos-11.0", "macos-10.15", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
.github/workflows/ci-unit-tests-os.patch.yml|28 col 17| value "macos-latest" in "exclude" does not match in matrix "os" combinations. possible values are "ubuntu-latest" [matrix]
.github/workflows/ci-unit-tests-os.yml|90 col 17| value "macos-latest" in "exclude" does not match in matrix "os" combinations. possible values are "ubuntu-latest" [matrix]
.github/workflows/ci-unit-tests-os.yml|137 col 9| shellcheck reported issue in this script: SC2028:info:2:6: echo may not expand escape sequences. Use printf [shellcheck]
.github/workflows/ci-unit-tests-os.yml|137 col 9| shellcheck reported issue in this script: SC2086:info:2:55: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-unit-tests-os.yml|137 col 9| shellcheck reported issue in this script: SC2028:info:3:6: echo may not expand escape sequences. Use printf [shellcheck]
.github/workflows/ci-unit-tests-os.yml|137 col 9| shellcheck reported issue in this script: SC2086:info:3:69: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-unit-tests-os.yml|147 col 9| shellcheck reported issue in this script: SC2086:info:1:38: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-unit-tests-os.yml|157 col 9| shellcheck reported issue in this script: SC2086:info:1:28: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-unit-tests-os.yml|157 col 9| shellcheck reported issue in this script: SC2086:info:2:42: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/manual-zcashd-deploy.yml|59 col 9| shellcheck reported issue in this script: SC2086:info:14:46: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/sub-build-docker-image.yml|61 col 14| label "ubuntu-latest-xl" is unknown. available labels are "windows-latest", "windows-2022", "windows-2019", "windows-2016", "ubuntu-latest", "ubuntu-22.04", "ubuntu-20.04", "ubuntu-18.04", "macos-latest", "macos-latest-xl", "macos-13-xl", "macos-13", "macos-13.0", "macos-12-xl", "macos-12", "macos-12.0", "macos-11", "macos-11.0", "macos-10.15", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
.github/workflows/sub-deploy-integration-tests-gcp.yml|113 col 14| label "zfnd-runners" is unknown. available labels are "windows-latest", "windows-2022", "windows-2019", "windows-2016", "ubuntu-latest", "ubuntu-22.04", "ubuntu-20.04", "ubuntu-18.04", "macos-latest", "macos-latest-xl", "macos-13-xl", "macos-13", "macos-13.0", "macos-12-xl", "macos-12", "macos-12.0", "macos-11", "macos-11.0", "macos-10.15", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
.github/workflows/sub-deploy-integration-tests-gcp.yml|186 col 9| shellcheck reported issue in this script: SC2086:info:27:57: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/sub-deploy-integration-tests-gcp.yml|186 col 9| shellcheck reported issue in this script: SC2086:info:34:57: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/sub-deploy-integration-tests-gcp.yml|186 col 9| shellcheck reported issue in this script: SC2086:info:41:57: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/sub-deploy-integration-tests-gcp.yml|186 col 9| shellcheck reported issue in this script: SC2129:style:65:1: Consider using { cmd1; cmd2; } >> file instead of individual redirects [shellcheck]
.github/workflows/sub-deploy-integration-tests-gcp.yml|515 col 9| shellcheck reported issue in this script: SC2086:info:1:69: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/sub-find-cached-disks.yml|55 col 9| shellcheck reported issue in this script: SC2086:info:2:37: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/sub-test-zebra-config.yml|49 col 9| shellcheck reported issue in this script: SC2086:info:23:10: Double quote to prevent globbing and word splitting [shellcheck]