Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Try to remove warnings of cargo deny check bans #7805

Closed
wants to merge 1 commit into from

Conversation

oxarbitrage
Copy link
Contributor

Motivation

When i run in the main branch i get the following warnings:

alfredo@spaceship:~/zebra/issue6532/zebra$ cargo deny check bans
warning[unmatched-skip-root]: skip tree root was not found in the dependency graph
   ┌─ /home/alfredo/zebra/issue6532/zebra/deny.toml:78:5
   │
78 │     { name = "rustls", version = "=0.20.9" },
   │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no crate matched these criteria

warning[unmatched-skip-root]: skip tree root was not found in the dependency graph
   ┌─ /home/alfredo/zebra/issue6532/zebra/deny.toml:81:5
   │
81 │     { name = "webpki-roots", version = "=0.22.6" },
   │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no crate matched these criteria

warning[unmatched-skip-root]: skip tree root was not found in the dependency graph
    ┌─ /home/alfredo/zebra/issue6532/zebra/deny.toml:104:5
    │
104 │     { name = "semver", version = "=0.9.0" },
    │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no crate matched these criteria

warning[unmatched-skip-root]: skip tree root was not found in the dependency graph
    ┌─ /home/alfredo/zebra/issue6532/zebra/deny.toml:109:5
    │
109 │     { name = "elasticsearch", version = "=8.5.0-alpha.1" },
    │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no crate matched these criteria

bans ok
alfredo@spaceship:~/zebra/issue6532/zebra$ 

Solution

This is just a test by now.

Review

Just a test.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

Follow Up Work

@oxarbitrage oxarbitrage added the do-not-merge Tells Mergify not to merge this PR label Oct 23, 2023
@oxarbitrage oxarbitrage self-assigned this Oct 23, 2023
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge labels Oct 23, 2023
@teor2345
Copy link
Contributor

The command you're using checks the default features, but we avoid duplicate dependencies for any features. So you'll want to use --all-features.

The easiest way to do this is to check the --all-features job on main:
https://github.com/ZcashFoundation/zebra/actions/runs/6617978958/job/17975427870#step:5:14

I've added detailed instructions to the deny.toml instructions:
https://github.com/ZcashFoundation/zebra/pull/7806/files

@oxarbitrage
Copy link
Contributor Author

does not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG do-not-merge Tells Mergify not to merge this PR extra-reviews This PR needs at least 2 reviews to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants