Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(deps): Remove unused deny.toml duplicate dependency exceptions #7818

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

These dependency exceptions are unused because Zebra no longer depends on those crate versions. (Some other dependency has stopped using them.)

Details are here:
https://github.com/ZcashFoundation/zebra/blob/main/book/src/dev/continuous-integration.md#fixing-unmatched-skip-root-warnings-in-check-denytoml-bans

@teor2345 teor2345 added A-dependencies Area: Dependency file updates C-cleanup Category: This is a cleanup P-Low ❄️ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 25, 2023
@teor2345 teor2345 self-assigned this Oct 25, 2023
@teor2345 teor2345 requested a review from a team as a code owner October 25, 2023 02:36
@teor2345 teor2345 requested review from arya2 and removed request for a team October 25, 2023 02:36
@github-actions github-actions bot added the extra-reviews This PR needs at least 2 reviews to merge label Oct 25, 2023
@teor2345 teor2345 removed the extra-reviews This PR needs at least 2 reviews to merge label Oct 25, 2023
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-actions github-actions bot added the extra-reviews This PR needs at least 2 reviews to merge label Oct 26, 2023
@teor2345 teor2345 removed the extra-reviews This PR needs at least 2 reviews to merge label Oct 26, 2023
mergify bot added a commit that referenced this pull request Oct 27, 2023
@mergify mergify bot merged commit d145526 into main Oct 27, 2023
69 checks passed
@mergify mergify bot deleted the unused-dups branch October 27, 2023 01:05
@teor2345 teor2345 mentioned this pull request Nov 5, 2023
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants