change(consensus): Lower mandatory checkpoint height #8629
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to support full validation of blocks from Canopy activation onwards, particularly for full validation of Canopy blocks on Regtest (though this use case also relies on supporting block construction for Canopy blocks).
Closes #8430.
Specifications & References
https://zips.z.cash/zip-0212
Solution
Lowers mandatory checkpoint height to the block before Canopy activation.
Tests
The mandatory checkpoint height test was updated to expect the last pre-Canopy block height.
Running a sync test locally with checkpoint sync disabled and an added checkpoint at height
1_046_399
until it gets past the grace periodFollow-up Work
PR Author's Checklist
PR Reviewer's Checklist