-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add public getter / setter func to Zebra-RPC::methods.rs #9113
Add public getter / setter func to Zebra-RPC::methods.rs #9113
Conversation
…ic_func_for_zaino_pt2
…ic_func_for_zaino_pt2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you for this change.
I left a few optional suggestions for cleanup.
@Mergifyio update |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
@idky137 By the way, it would also be fine to make RPC request/response type fields public in the future if that's easier. This PR will need the latest changes on main to pass CI. |
…ic_func_for_zaino_pt2
Oh cool I wasn't sure if you wanted to keep fields private. I think this will be everything we need publicised but I will keep that in mind i the future! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Motivation
Adds public getter and setter functionality to RPC method responses in Zebra-RPC to enable Zaino to construct and deconstruct these types.
Specifications & References
Solution
Add public getter and setter methods to structs in Zebra-RPC::methods.rs
Tests
Follow-up Work
PR Author's Checklist
PR Reviewer's Checklist