fix(workflows): update patch jobs conditions and naming #9117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavovalverde
added
C-bug
gustavovalverde
requested review from
oxarbitrage
and removed request for
a team
github-actions
bot
added
the
C-trivial
- Modified job conditions in multiple workflow files to ensure they only run for pull requests from external repositories. - Updated job names for clarity and consistency across `cd-deploy-nodes-gcp`, `ci-tests`, and `docs-deploy-firebase` workflows, and to sync them with our rulesets - Enhanced comments to emphasize the importance of synchronizing job names across related workflow files. Fixes #9108
gustavovalverde
force-pushed
the
fix-patch-workflows
branch
from
6cbf4d9 to
6181c59
Compare
upbqdn
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some PRs get stuck as we had to update our required workflows configuration after refactoring mergify. GitHub rulesets now recommends using the whole workflow name path, for example:
Unit tests / Test CI default Docker config file / Test default-conf in Dockerbased on the names of the jobs chain generated by the reusable workflows.Fixes #9108
Specifications & References
Solution
cd-deploy-nodes-gcp,ci-tests, anddocs-deploy-firebaseworkflows, and to sync them with our rulesetsPR Author's Checklist
PR Reviewer's Checklist