Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CI): Remove the "Release crates" workflow #9119

Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix(CI): Remove the "Release crates" workflow #9119

merged 1 commit into from
Jan 14, 2025

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Jan 14, 2025

Motivation

Fix https://github.com/ZcashFoundation/zebra/actions/runs/12751834865/job/35539829251?pr=9114.

Solution

  • Remove the workflow and its associated bash script.

Rationale

It didn't catch publishing issues in the past, and it skips a bunch of things anyway.

..., it wasn't doing much with --no-verify anyway.

It was working fine with the previous version of Rust. I think the latest stable version broke --no-verify, because it wasn't pulling dependencies from crates.io before (which is how we ended up with git sources on main when we were trying to publish Zebra), but now it does even if --no-verify is passed in explicitly.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@upbqdn upbqdn added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-High 🔥 labels Jan 14, 2025
@upbqdn upbqdn self-assigned this Jan 14, 2025
@upbqdn upbqdn requested review from a team as code owners January 14, 2025 19:22
@upbqdn upbqdn requested review from gustavovalverde and oxarbitrage and removed request for a team January 14, 2025 19:22
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge labels Jan 14, 2025
@upbqdn upbqdn mentioned this pull request Jan 14, 2025
Merged
7 tasks
arya2
arya2 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@upbqdn upbqdn merged commit a3d2341 into fix-clippy-lints Jan 14, 2025
94 checks passed
@upbqdn upbqdn deleted the remove-release-job branch January 14, 2025 19:25
@upbqdn upbqdn removed extra-reviews This PR needs at least 2 reviews to merge C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Jan 14, 2025
mergify bot pushed a commit that referenced this pull request Jan 14, 2025
@upbqdn
chore: Fix new clippy lints (#9114)
410cac0 
* Fix lints

* chore: Release

* Remove the "release crates" job (#9119)
@upbqdn upbqdn mentioned this pull request Jan 15, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 approved these changes

@gustavovalverde gustavovalverde Awaiting requested review from gustavovalverde gustavovalverde was automatically assigned from ZcashFoundation/devops-reviewers

@oxarbitrage oxarbitrage Awaiting requested review from oxarbitrage oxarbitrage was automatically assigned from ZcashFoundation/general-rust-reviewers

Assignees

@upbqdn upbqdn

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug P-High 🔥
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@upbqdn @arya2