Update JWS, JWT implementation #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesusMcCloud
requested changes
Apr 9, 2024
| @@ -27,14 +27,12 @@ data class JsonWebKey( | |||
| val type: JwkType? = null, | |||
| @SerialName("kid") | |||
| val keyId: String? = null, | |||
| //EC | |||
There was a problem hiding this comment.
Why remove the comment?
There was a problem hiding this comment.
Because it's not a KDoc comment, so it's not visible from outside the source code, and it provides no added value.
There was a problem hiding this comment.
since this class mixes up rsa and ec properties as per the spec, I do feel it provides added value to maintainers of the code base
| } | ||
| } | ||
|
|
||
| private fun ByteArray.decodeX5c() = decodeToString() |
There was a problem hiding this comment.
A function like that should not be just a private utility in KMP-Crypto.
It would make more sense to add it to the certificate class, for example, because it provides added value in general.
JesusMcCloud
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update data classes as a prerequisite to a-sit-plus/vck#48
Also cc'ing @n0900