Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wording for OpenID4VP #193

Closed
wants to merge 9 commits into from

Conversation

nodh
Copy link
Contributor

@nodh nodh commented Jan 14, 2025

Get rid of the naming SIOP and replace with the correct term OpenID4VP, also cleaning up the huge classes a bit.

Fixes #153

@nodh nodh requested a review from JesusMcCloud January 14, 2025 16:44
@nodh nodh self-assigned this Jan 14, 2025
Copy link
Collaborator

@JesusMcCloud JesusMcCloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodh nodh force-pushed the feature/siop-verifier branch from 49964a0 to 3d7b3de Compare January 16, 2025 11:32
@nodh nodh force-pushed the feature/iso-18013-7-annex-b branch from 693c357 to 11affb6 Compare January 16, 2025 11:33
@nodh nodh force-pushed the feature/siop-verifier branch from 3d7b3de to d228ec7 Compare January 16, 2025 11:33
@nodh
Copy link
Contributor Author

nodh commented Jan 16, 2025

Merged into develop

@nodh nodh closed this Jan 16, 2025
@nodh nodh deleted the feature/siop-verifier branch January 16, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants