EUDI Interop #41
Merged
EUDI Interop #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows callers to request different credential schemes with the same instance of the class
JesusMcCloud
previously requested changes
Mar 18, 2024
| ) { | ||
|
|
||
| fun serialize() = jsonSerializer.encodeToString(this) | ||
|
|
||
| override fun equals(other: Any?): Boolean { |
There was a problem hiding this comment.
where are the regression tests? Serious question here: do we know equality checks still work?
| issuer = issuer, | ||
| issuanceDate = issuanceDate, | ||
| expirationDate = issuanceDate + lifetime, | ||
| credentialStatus = null, | ||
| credentialSubject = credentialSubject, | ||
| ) | ||
|
|
||
| override fun equals(other: Any?): Boolean { |
There was a problem hiding this comment.
again: do we know equality checks still work?
| @@ -38,40 +38,6 @@ data class VerifiableCredentialSdJwt( | |||
|
|
|||
| fun serialize() = jsonSerializer.encodeToString(this) | |||
|
|
|||
| override fun equals(other: Any?): Boolean { | |||
| @@ -30,25 +30,4 @@ data class VerifiablePresentation( | |||
| audience = audienceId, | |||
| jwtId = id | |||
| ) | |||
|
|
|||
| override fun equals(other: Any?): Boolean { | |||
| val revokedVerifiableCredentials: Array<VerifiableCredentialJws> = arrayOf(), | ||
| val invalidVerifiableCredentials: Array<String> = arrayOf(), | ||
| ) { | ||
| override fun equals(other: Any?): Boolean { |
| @@ -10,20 +10,5 @@ import kotlinx.serialization.Serializable | |||
| @Serializable | |||
| data class FormatContainerLdp( | |||
| @SerialName("proof_type") | |||
| val proofType: Array<String>, | |||
| ) { | |||
| override fun equals(other: Any?): Boolean { | |||
| constraints = constraints, | ||
| ) | ||
|
|
||
| override fun equals(other: Any?): Boolean { |
| formats: FormatHolder | ||
| ) : this(id = uuid4().toString(), inputDescriptors = inputDescriptors, formats = formats) | ||
|
|
||
| fun serialize() = jsonSerializer.encodeToString(this) | ||
|
|
||
| override fun equals(other: Any?): Boolean { |
| @@ -14,28 +14,5 @@ data class PresentationSubmission( | |||
| @SerialName("definition_id") | |||
| val definitionId: String, | |||
| @SerialName("descriptor_map") | |||
| val descriptorMap: Array<PresentationSubmissionDescriptor>? = null, | |||
| ) { | |||
| override fun equals(other: Any?): Boolean { | |||
| @@ -24,38 +24,5 @@ data class SubmissionRequirement( | |||
| @SerialName("from") | |||
| val from: String? = null, | |||
| @SerialName("from_nested") | |||
| val fromNested: Array<SubmissionRequirement>? = null, | |||
| ) { | |||
| override fun equals(other: Any?): Boolean { | |||
JesusMcCloud
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on interop with EUDI credentials