Thorough request object retrieval algorithm

[acrusage-iaik]

Improved algorithm for retrieving AuthenticationResponseParameters as asked for in a-sit-plus/valera#61 (comment)

[JesusMcCloud]

The implementation looks really good, but it would be nice to have both cases tested and not only the baseline one we hade before (even though it is important to keep it as regression test)

[acrusage-iaik]

The implementation looks really good, but it would be nice to have both cases tested and not only the baseline one we hade before (even though it is important to keep it as regression test)

I might need help with that, I'm not sure how to provide a dummy response to a HttpClient.get request

[acrusage-iaik]

The implementation looks really good, but it would be nice to have both cases tested and not only the baseline one we hade before (even though it is important to keep it as regression test)

fixed in commit 19b4614

[nodh]

I'm unhappy with the added dependency on HttpClient from ktor ... is this really necessary?

[JesusMcCloud]

how would you make an http request, without an http client?

[nodh]

imho as as the prefix indicates a function, but this is a property

[nodh]

how would you make an http request, without an http client?

Why don't we leave that up to the client, i.e. the caller of our library, as it has been the case up until now?

[acrusage-iaik]

how would you make an http request, without an http client?

Why don't we leave that up to the client, i.e. the caller of our library, as it has been the case up until now?

fixed in commit 03a0cdd
prepared at pull request #46 along with a fix for #45 (comment)