cli: improve output of update command

Signed-off-by: Abiola Ibrahim <[email protected]>

app/app.go

@@ -471,7 +471,22 @@ func (c *colimaApp) Update() error {
 		return err
 	}
 
-	return container.Update(ctx)
+	oldVersion := container.Version(ctx)
+
+	updated, err := container.Update(ctx)
+	if err != nil {
+		return err
+	}
+
+	if updated {
+		fmt.Println("previous version")
+		fmt.Println(oldVersion)
+		fmt.Println()
+		fmt.Println("current version")
+		fmt.Println(container.Version(ctx))
+	}
+
+	return nil
 }
 
 func generateSSHConfig(modifySSHConfig bool) error {

environment/container.go

@@ -23,7 +23,7 @@ type Container interface {
 	// Teardown tears down/uninstall the container runtime.
 	Teardown(ctx context.Context) error
 	// Update the container runtime.
-	Update(ctx context.Context) error
+	Update(ctx context.Context) (bool, error)
 	// Version returns the container runtime version.
 	Version(ctx context.Context) string
 	// Running returns if the container runtime is currently running.

environment/container/containerd/containerd.go

@@ -103,6 +103,6 @@ func (c containerdRuntime) Version(ctx context.Context) string {
 	return version
 }
 
-func (c *containerdRuntime) Update(ctx context.Context) error {
-	return fmt.Errorf("update not supported for the %s runtime", Name)
+func (c *containerdRuntime) Update(ctx context.Context) (bool, error) {
+	return false, fmt.Errorf("update not supported for the %s runtime", Name)
 }

environment/container/docker/docker.go

@@ -135,7 +135,7 @@ func (d dockerRuntime) Version(ctx context.Context) string {
 	return version
 }
 
-func (d *dockerRuntime) Update(ctx context.Context) error {
+func (d *dockerRuntime) Update(ctx context.Context) (bool, error) {
 	packages := []string{
 		"docker-ce",
 		"docker-ce-cli",

environment/container/incus/incus.go

@@ -280,7 +280,7 @@ type networkInfo struct {
 	Type    string `json:"type"`
 }
 
-func (c *incusRuntime) Update(ctx context.Context) error {
+func (c *incusRuntime) Update(ctx context.Context) (bool, error) {
 	packages := []string{
 		"incus",
 		"incus-base",

environment/container/kubernetes/kubernetes.go

@@ -264,7 +264,6 @@ func (c kubernetesRuntime) Version(context.Context) string {
 	return version
 }
 
-func (c *kubernetesRuntime) Update(ctx context.Context) error {
-	// update not supported
-	return nil
+func (c *kubernetesRuntime) Update(ctx context.Context) (bool, error) {
+	return false, fmt.Errorf("update not supported for the %s runtime", Name)
 }

util/debutil/debutil.go

@@ -34,13 +34,14 @@ func UpdateRuntime(
 	chain cli.CommandChain,
 	runtime string,
 	packageNames ...string,
-) error {
+) (bool, error) {
 	a := chain.Init(ctx)
 	log := a.Logger()
 
 	packages := packages(packageNames)
 
-	updatesAvailable := false
+	hasUpdates := false
+	updated := false
 
 	a.Stage("refreshing package manager")
 	a.Add(func() error {
@@ -58,12 +59,12 @@ func UpdateRuntime(
 			"-c",
 			packages.Upgradable(),
 		)
-		updatesAvailable = err == nil
+		hasUpdates = err == nil
 		return nil
 	})
 
 	a.Add(func() (err error) {
-		if !updatesAvailable {
+		if !hasUpdates {
 			log.Warnf("no updates available for %s runtime", runtime)
 			return
 		}
@@ -75,10 +76,13 @@ func UpdateRuntime(
 			packages.Install(),
 		)
 		if err == nil {
+			updated = true
 			log.Println("done")
 		}
 		return
 	})
 
-	return a.Exec()
+	// it is necessary to execute the chain here to get the correct value for `updated`.
+	err := a.Exec()
+	return updated, err
 }