Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incremental backoff jitter #955

Merged
merged 20 commits into from
Jul 5, 2023
Merged

Fix incremental backoff jitter #955

merged 20 commits into from
Jul 5, 2023

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Jun 21, 2023 •
edited by jamienewcomb
Loading

@sacOO7 sacOO7 changed the title Refactor/incremental backoff jitter Fix incremental backoff jitter Jun 21, 2023
@sacOO7 sacOO7 force-pushed the refactor/incremental-backoff-jitter branch from 1052e13 to 5476b35 Compare June 22, 2023 07:53
@sacOO7
Copy link
Collaborator Author

sacOO7 commented Jun 22, 2023 •
edited
Loading

Flaky integration tests are being fixed with #949

@sacOO7 sacOO7 marked this pull request as ready for review June 22, 2023 08:46
@sacOO7 sacOO7 force-pushed the refactor/incremental-backoff-jitter branch from 4033cfc to 8a26519 Compare June 22, 2023 14:00
@sacOO7 sacOO7 mentioned this pull request Jun 23, 2023
Closed
@sacOO7 sacOO7 requested a review from AndyTWF July 4, 2023 12:03
owenpearson
owenpearson requested changes Jul 5, 2023
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests look fine to me, i'm not sure about the disconnect retry implementation though:

lib/src/main/java/io/ably/lib/transport/ConnectionManager.java Show resolved Hide resolved
@sacOO7 sacOO7 requested a review from owenpearson July 5, 2023 16:20
owenpearson
owenpearson approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@owenpearson owenpearson merged commit 63e5b9a into ably:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyTWF AndyTWF AndyTWF approved these changes

@owenpearson owenpearson owenpearson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix incremental backoff while reconnecting + refactor tests
3 participants
@sacOO7 @AndyTWF @owenpearson