MG-213 - Update Gauges to fetch data from the back-end readers #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixgateru
requested changes
Mar 11, 2024
ianmuchyri
requested changes
Mar 12, 2024
dborovcanin
force-pushed
the
analoguegauge
branch
from
e388842 to
a74f5b3
Compare
Musilah
force-pushed
the
analoguegauge
branch
4 times, most recently
from
a422344 to
0f89e07
Compare
ianmuchyri
requested changes
Mar 14, 2024
ianmuchyri
requested changes
Mar 14, 2024
Musilah
force-pushed
the
analoguegauge
branch
3 times, most recently
from
aecef6f to
f2c61eb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
=======================================
Coverage ? 81.00%
=======================================
Files ? 3
Lines ? 179
Branches ? 0
=======================================
Hits ? 145
Misses ? 18
Partials ? 16 ☔ View full report in Codecov by Sentry. |
Musilah
force-pushed
the
analoguegauge
branch
2 times, most recently
from
4c8b7bf to
f6ff95d
Compare
felixgateru
requested changes
Mar 20, 2024
felixgateru
requested changes
Mar 21, 2024
ui/web/static/js/charts.js
Outdated
Comment on lines
1210
to
1172
| console.log("response: ", response.url); | ||
| console.log("data: ", data.messages); |
There was a problem hiding this comment.
remove debug statements
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
This PR updates the simple analogue gauge, temp and speed gauges as well as the multigauge
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes