Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common - Check extensions hash #10144

Merged
merged 13 commits into from
Jan 13, 2025
Merged

Common - Check extensions hash #10144

merged 13 commits into from
Jan 13, 2025
+100 −15

Conversation

PabstMirror
Copy link
Contributor

Verifies extensions hash

@PabstMirror PabstMirror added kind/enhancement Release Notes: **IMPROVED:** 2.18 labels Jul 25, 2024
@PabstMirror PabstMirror added this to the Ongoing milestone Jul 25, 2024
@jonpas
Copy link
Member

jonpas commented Jul 25, 2024

Add to existing ACE_Extensions?

@PabstMirror
Copy link
Contributor Author

we're dropping that in rust pr #9015, this should be compatible before/after that

@johnb432 johnb432 modified the milestones: Ongoing, 3.18.2 Oct 12, 2024
@johnb432 johnb432 removed the 2.18 label Oct 12, 2024
johnb432
johnb432 approved these changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hashes returned in game are capitalised, whereas the ones the tool returns are lowercase. I don't think it will pose issues though, given the case-insensitive comparison, so LGTM.

@PabstMirror PabstMirror modified the milestones: 3.18.2, Ongoing Oct 15, 2024
@PabstMirror
Copy link
Contributor Author

PabstMirror commented Oct 15, 2024 •
edited
Loading

  • Add setting

johnb432
johnb432 approved these changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

addons/common/functions/fnc_checkFiles.sqf Show resolved Hide resolved
addons/common/functions/fnc_checkFiles.sqf Outdated Show resolved Hide resolved
@LinkIsGrim LinkIsGrim removed this from the Ongoing milestone Jan 13, 2025
@LinkIsGrim LinkIsGrim modified the milestones: 3.18.3, 3.18.2 Jan 13, 2025
@LinkIsGrim LinkIsGrim merged commit 2bfb226 into master Jan 13, 2025
3 checks passed
@LinkIsGrim LinkIsGrim deleted the checkExtensionHash branch January 13, 2025 20:01
PlayerBotPro pushed a commit to PlayerBotPro/ACE3 that referenced this pull request Jan 14, 2025
@PabstMirror @johnb432
@LinkIsGrim @PlayerBotPro
Common - Check extensions hash (acemod#10144)
8d3a17d 
Co-authored-by: johnb432 <[email protected]>
Co-authored-by: Grim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

@johnb432 johnb432 johnb432 approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.19.0
Development

Successfully merging this pull request may close these issues.
4 participants
@PabstMirror @jonpas @johnb432 @LinkIsGrim