Interaction - Add Interaction to take another players launcher

[Cplhardcore]

When merged this pull request will:

• Allow players to take launchers off others backs, without needing to go through the inventory

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[Cplhardcore]

Right now this PR is on hold, as support for multiple muzzles breaks disposables

[Cplhardcore]

thanks to johnb, this PR should be good to go

[Mike-MF]

Only thing i can see. LGTM otherwise.

[johnb432]

Suggested change

	if (GVAR(enableLauncherTaking) &&
	secondaryWeapon _target != "" &&
	secondaryWeapon _player == "" &&
	isNull objectParent _target &&
	isNull objectParent _player &&
	side _target == side _player) exitWith {true};
	false
	GVAR(enableLauncherTaking) &&
	secondaryWeapon _target != "" &&
	secondaryWeapon _player == "" &&
	isNull objectParent _target &&
	isNull objectParent _player &&
	side _target == side _player

I'd personally also wrap every single statement in a lazy eval, but I haven't tested the performance impact.

[johnb432]

I don't think this would work when the target is unconscious, as side changes. Imo would be better to check if the sides have friendly relations (using the sides of the group).

[johnb432]

Still not a huge fan of this tbh. There's no way you can object to having your launcher taken.
I'd much prefer if you need to confirm that you want someone to take your launcher (uncon would automatically confirm).

[johnb432]

Suggested change

	[QEGVAR(common,displayTextStructured), [[LSTRING(TakingLauncherHint), _playerName, _displayName], 1.5, _target], [_target]] call CBA_fnc_targetEvent;
	[QEGVAR(common,displayTextStructured), [[LSTRING(TakingLauncherHint), _playerName, _displayName], 1.5, _target], _target] call CBA_fnc_targetEvent;

[johnb432]

Suggested change

	[QEGVAR(common,displayTextStructured), [[LSTRING(GaveLauncherHint), _playerName, _displayName], 1.5, _target], [_target]] call CBA_fnc_targetEvent;
	[QEGVAR(common,displayTextStructured), [[LSTRING(TookLauncherHint), _targetName, _displayName], 1.5, _player], [_player]] call CBA_fnc_targetEvent;
	[QEGVAR(common,displayTextStructured), [[LSTRING(GaveLauncherHint), _playerName, _displayName], 1.5, _target], _target] call CBA_fnc_targetEvent;
	[QEGVAR(common,displayTextStructured), [[LSTRING(TookLauncherHint), _targetName, _displayName], 1.5, _player], _player] call CBA_fnc_targetEvent;

[johnb432]

Even though I prefer this variant, imo it's better to keep consistent styling within the same file when possible.

Suggested change

	QGVAR(launcherTime),
	"SLIDER",
	QGVAR(launcherTime), "SLIDER",

[johnb432]

Suggested change

	true
	1

[johnb432]

1. Not a fan of the default value, imo it should be off.
2. This should be a synced setting imo.