Map Tools - Fix drawing straight lines #10635
Merged
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabstMirror
approved these changes
Jan 10, 2025
LinkIsGrim
approved these changes
Jan 13, 2025
LinkIsGrim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
As mentioned here, since 2.18
allMapMarkersis ordered according to priority first, instead of creation. That causes those markers with higher priority to always be at the end of the array.The current code however still assumes that
allMapMarkers select -1is always the line that was just drawn, causing it to compare the cachedGVAR(drawPosStart)with the wrong marker and always aborting line straightening due to the distance check.