Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat EF - Remove ace_hearing hard dependency #10646

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • The hard dependency is only an issue if you build with --no-rap, but I'd still like to rectify the issue fully.

Need the following 3 questions answered:

  1. Is this wanted?

If so:

  1. Do I rectify the other components that need it as well?
  2. Should this be included in the release changelog?

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added this to the 3.18.3 milestone Jan 13, 2025
@LinkIsGrim LinkIsGrim added the kind/bug-fix Release Notes: **FIXED:** label Jan 13, 2025
@LinkIsGrim
Copy link
Contributor

  1. Yes
  2. Yes
  3. Only for components that existed before 3.18.2

@LinkIsGrim LinkIsGrim changed the title EF Compat - Remove ace_hearing hard dependency Compat EF - Remove ace_hearing hard dependency Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants