Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goggles - Use CBA_fnc_addBISPlayerEventHandler #10650

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Goggles - Use CBA_fnc_addBISPlayerEventHandler #10650

merged 1 commit into from
Jan 13, 2025

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Title.
  • Previously virtual units weren't excluded from having the EH assigned. CBA_fnc_addBISPlayerEventHandler excludes virtual units by default. Thoughts?

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/optimization Release Notes: **IMPROVED:** label Jan 13, 2025
@johnb432 johnb432 added this to the 3.18.3 milestone Jan 13, 2025
@LinkIsGrim LinkIsGrim modified the milestones: 3.18.3, 3.18.2 Jan 13, 2025
@LinkIsGrim LinkIsGrim changed the title Goggles - Replace class EH with CBA_fnc_addBISPlayerEventHandler Goggles - Use CBA_fnc_addBISPlayerEventHandler Jan 13, 2025
@LinkIsGrim LinkIsGrim merged commit 74a7bbb into master Jan 13, 2025
3 checks passed
@PabstMirror
Copy link
Contributor

I don't think we want spectators to have any effects

@LinkIsGrim LinkIsGrim deleted the goggles-remove-class-eh branch January 13, 2025 19:54
@johnb432
Copy link
Contributor Author

I don't think we want spectators to have any effects

The explosion EH deals 0 damage on units that are invulnerable, so they never could get them.

PlayerBotPro pushed a commit to PlayerBotPro/ACE3 that referenced this pull request Jan 14, 2025
@johnb432 @PlayerBotPro
Goggles - Use CBA_fnc_addBISPlayerEventHandler (acemod#10650)
9e813be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@johnb432 @PabstMirror @LinkIsGrim