Pike - Laser guided 40mm grenade #6731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedmen
reviewed
Dec 14, 2018
How did you test? |
|
Changing
It's kinda funny because you can still fire like this (it goes straight up) |
|
Want to keep this around @PabstMirror? |
PabstMirror
added
kind/feature
PabstMirror
changed the title
PabstMirror
changed the title
rautamiekka
suggested changes
Oct 15, 2023
| // If we didn't get a target, try to fall back on tab locking | ||
| if (isNil "_target") then { | ||
| if (!isPlayer _shooter) then { | ||
| // This was an AI shot, lets still guide it on the AI target |
There was a problem hiding this comment.
Suggested change
| // This was an AI shot, lets still guide it on the AI target | |
| // This was an AI shot, let's still guide it on the AI target |
There was a problem hiding this comment.
onFiredDeferred is just a copy of ace_missileguidance_fnc_onFired with slight changes to start and end
so I'd really like to just keep it unchanged
to make it easy as possible to migrate it to the missile guidance rework PR
Comment on lines
87
to
106
| [ _shooter, | ||
| [_target, _targetPos, _launchPos], | ||
| _seekerType, | ||
| _attackProfile, | ||
| _lockMode, | ||
| _laserInfo | ||
| ], | ||
| [ | ||
| getNumber ( _config >> "minDeflection" ), | ||
| getNumber ( _config >> "maxDeflection" ), | ||
| getNumber ( _config >> "incDeflection" ) | ||
| ], | ||
| [ | ||
| getNumber ( _config >> "seekerAngle" ), | ||
| getNumber ( _config >> "seekerAccuracy" ), | ||
| getNumber ( _config >> "seekerMaxRange" ), | ||
| getNumber ( _config >> "seekerMinRange" ) | ||
| ], | ||
| [ diag_tickTime, [], [], _lastKnownPosState] | ||
| ]; |
There was a problem hiding this comment.
Suggested change
| [ _shooter, | |
| [_target, _targetPos, _launchPos], | |
| _seekerType, | |
| _attackProfile, | |
| _lockMode, | |
| _laserInfo | |
| ], | |
| [ | |
| getNumber ( _config >> "minDeflection" ), | |
| getNumber ( _config >> "maxDeflection" ), | |
| getNumber ( _config >> "incDeflection" ) | |
| ], | |
| [ | |
| getNumber ( _config >> "seekerAngle" ), | |
| getNumber ( _config >> "seekerAccuracy" ), | |
| getNumber ( _config >> "seekerMaxRange" ), | |
| getNumber ( _config >> "seekerMinRange" ) | |
| ], | |
| [ diag_tickTime, [], [], _lastKnownPosState] | |
| ]; | |
| [ _shooter, | |
| [_target, _targetPos, _launchPos], | |
| _seekerType, | |
| _attackProfile, | |
| _lockMode, | |
| _laserInfo | |
| ], | |
| [ | |
| getNumber ( _config >> "minDeflection" ), | |
| getNumber ( _config >> "maxDeflection" ), | |
| getNumber ( _config >> "incDeflection" ) | |
| ], | |
| [ | |
| getNumber ( _config >> "seekerAngle" ), | |
| getNumber ( _config >> "seekerAccuracy" ), | |
| getNumber ( _config >> "seekerMaxRange" ), | |
| getNumber ( _config >> "seekerMinRange" ) | |
| ], | |
| [diag_tickTime, [], [], _lastKnownPosState] | |
| ]; |
rautamiekka
suggested changes
Oct 23, 2023
Comment on lines
23
to
34
| if ((getNumber (configFile >> "CfgAmmo" >> _ammo >> QUOTE(ADDON) >> "enabled")) != 2) exitWith { ERROR("not enabled=2"); [] }; | ||
|
|
||
| // MissileGuidance is enabled for this shot | ||
| TRACE_4("enabled",_shooter,_ammo,_projectile,typeOf _shooter); | ||
|
|
||
| private _config = configFile >> "CfgAmmo" >> _ammo >> QUOTE(ADDON); | ||
|
|
||
| private _target = _shooter getVariable [QGVAR(target), nil]; | ||
| private _targetPos = _shooter getVariable [QGVAR(targetPosition), nil]; | ||
| private _seekerType = _shooter getVariable [QGVAR(seekerType), nil]; | ||
| private _attackProfile = _shooter getVariable [QGVAR(attackProfile), nil]; | ||
| if ((getNumber (configFile >> "CfgAmmo" >> _ammo >> QUOTE(ADDON) >> "useModeForAttackProfile")) == 1) then { |
There was a problem hiding this comment.
Suggested change
| if ((getNumber (configFile >> "CfgAmmo" >> _ammo >> QUOTE(ADDON) >> "enabled")) != 2) exitWith { ERROR("not enabled=2"); [] }; | |
| // MissileGuidance is enabled for this shot | |
| TRACE_4("enabled",_shooter,_ammo,_projectile,typeOf _shooter); | |
| private _config = configFile >> "CfgAmmo" >> _ammo >> QUOTE(ADDON); | |
| private _target = _shooter getVariable [QGVAR(target), nil]; | |
| private _targetPos = _shooter getVariable [QGVAR(targetPosition), nil]; | |
| private _seekerType = _shooter getVariable [QGVAR(seekerType), nil]; | |
| private _attackProfile = _shooter getVariable [QGVAR(attackProfile), nil]; | |
| if ((getNumber (configFile >> "CfgAmmo" >> _ammo >> QUOTE(ADDON) >> "useModeForAttackProfile")) == 1) then { | |
| private _config = configFile >> "CfgAmmo" >> _ammo >> QUOTE(ADDON); | |
| if ((getNumber (_config >> "enabled")) != 2) exitWith { ERROR("not enabled=2"); [] }; | |
| // MissileGuidance is enabled for this shot | |
| TRACE_4("enabled",_shooter,_ammo,_projectile,typeOf _shooter); | |
| private _target = _shooter getVariable [QGVAR(target), nil]; | |
| private _targetPos = _shooter getVariable [QGVAR(targetPosition), nil]; | |
| private _seekerType = _shooter getVariable [QGVAR(seekerType), nil]; | |
| private _attackProfile = _shooter getVariable [QGVAR(attackProfile), nil]; | |
| if ((getNumber (_config >> "useModeForAttackProfile")) == 1) then { |
| * Args <Array> | ||
| * | ||
| * Example: | ||
| * [player, "", "", "", "ACE_Javelin_FGM148", "", theMissile] call ace_missileguidance_fnc_onFiredDeffered |
There was a problem hiding this comment.
All instances of Deffered should be Deferred to be correct English.
| // Array for seek last target position | ||
| private _seekLastTargetPos = (getNumber ( _config >> "seekLastTargetPos")) == 1; | ||
| private _lastKnownPosState = [_seekLastTargetPos]; | ||
| if (_seekLastTargetPos && {!isNil "_target"}) then { |
There was a problem hiding this comment.
Surely the lazy eval + nil check is more expensive than the nil check alone ? The check is on a separate var as well.
Suggested change
| if (_seekLastTargetPos && {!isNil "_target"}) then { | |
| if (_seekLastTargetPos && !isNil "_target") then { |
Co-authored-by: Jouni Järvinen <[email protected]>
LinkIsGrim
approved these changes
Jan 13, 2025
LinkIsGrim
changed the title
PlayerBotPro
pushed a commit
to PlayerBotPro/ACE3
that referenced
this pull request
Jan 14, 2025
Co-authored-by: Jouni Järvinen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://en.wikipedia.org/wiki/Pike_(munition)
As far as I could tell, grenade launchers couldn't fire missiles, so I have to do the scripted ammo swap.
Model isn't great, but should be fine for the amount of time it's seen.
Still not positive on the flight characteristics, it should have a 2000m range
I'm not sure how to balance initial muzzle velocity, rocket impluse and burn time.
I also might adjust the attack profile to give it more of a ballistic arc