Add support for terminate job endpoint and unify request_and_check function #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note that I also increased the allowed line length to 88 characters in 75601cf. |
|
OK, 75601cf is reverted, so line length is 79 again and tests pass ... |
|
OK, I do now have a PR in the pipeline for STRDS support that builds upon this PR (esp the modified |
anikaweinmann
approved these changes
Nov 26, 2024
|
I hope we get our ruff configuration ready soon in https://github.com/mundialis/github-workflows so that we can use this. Thank you very much for your changes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for terminating jobs (which has not been implemented yet: https://github.com/actinia-org/actinia-python-client/blob/main/src/actinia/job.py#L117)
It also extends the
request_and_checkfunction so it can be used on all kinds of requests and thus across all modules...I have not checked tested all cases yet...
We are looking at using the python client more actively in ETL worksflows with Apache Airflow. So we may add support for STRDS (and similar additions) as well... Though no time line for that yet...