Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check allowed ranges for xsd:YearMonth and xsd:YearMonthDay triples #96

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

patrickbr
Copy link
Member

@patrickbr patrickbr commented Oct 10, 2024

This PR changes the behavior of the start_date and end_date writing behavior: if the xsd:YearMonth or xsd:YearMonthDay object would contain a month or a day outside the allowed range (1-12, 1-31, resp.), don't output it. It also adds some tests for this behavior.

I noticed that we output invalid values here while testing #58. During the E2E test, the TTL validation via QLever rightfully complains:

10:24:52 WARN  riot            :: [line: 9961932, col: 40] Lexical form '1831-18' not valid for datatype XSD gYearMonth

@lehmann-4178656ch lehmann-4178656ch merged commit 4caf2e1 into master Oct 10, 2024
@patrickbr patrickbr deleted the check-month-datatypes-validity branch October 10, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants