Skip to content

Commit

Permalink
remove TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
patrickbr committed Feb 15, 2024
1 parent eda6f50 commit 67b9f7f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
6 changes: 2 additions & 4 deletions src/pfaedle/router/ShapeBuilder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,6 @@ std::map<size_t, EdgeListHops> ShapeBuilder::shapeify(
const TripTrie<pfaedle::gtfs::Trip>* trie, HopCache* hopCache) const {
LOG(VDEBUG) << "Map-matching trie " << trie;

// TODO(patrick): assumes the trie is not empty, check this!
assert(trie->getNdTrips().size());
assert(trie->getNdTrips().begin()->second.size());
RoutingAttrs rAttrs = getRAttrs(trie->getNdTrips().begin()->second[0]);
Expand Down Expand Up @@ -838,9 +837,8 @@ double ShapeBuilder::timePen(int candTime, int schedTime) const {
// _____________________________________________________________________________
EdgeCandGroup ShapeBuilder::timeExpand(const EdgeCand& ec, int time) const {
EdgeCandGroup ret;
// TODO(patrick): heuristic for time expansion variance
// for (int i = -5; i < 6; i++) {
// for (int i = -10; i < 1; i++) {
// TODO(patrick): heuristic for time expansion variance, currently
// unused
for (int i = 0; i < 1; i++) {
EdgeCand ecNew = ec;
// in 30 sec steps
Expand Down
1 change: 0 additions & 1 deletion src/pfaedle/router/TripTrie.tpp
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@ size_t TripTrie<TRIP>::getMatchChild(size_t parentNid,
const std::string& platform, POINT pos,
int time, bool timeEx) const {
for (size_t child : _nds[parentNid].childs) {
// TODO(patrick): use similarity classification here?
if (_nds[child].stopName == stopName && _nds[child].platform == platform &&
util::geo::dist(_nds[child].pos, pos) < 1 &&
(!timeEx || _nds[child].time == time)) {
Expand Down

0 comments on commit 67b9f7f

Please sign in to comment.