New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement obb checks for Line and Area #4

Merged

patrickbr merged 1 commit into master from implement-obb

May 6, 2024

Member

lehmann-4178656ch commented May 2, 2024

This PR requires Implement getOrientedEnvelope using rotating calipers util#1
This PR activates previously commented code and adds statistics
It currently not implemented for
- checks with SimpleLines as these were not marked to have obbs
- Point/Area checks


          Implement obb checks for Line and Area

9109e28

lehmann-4178656ch requested a review from patrickbr

May 2, 2024 07:23

Member

patrickbr commented May 6, 2024

Thanks Axel, this is now merged in branch covers.

Please see also my comment on the failing tests here: ad-freiburg/util#1

patrickbr merged commit 22b36f7 into master

5 of 6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet