Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convex hull #7

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Convex hull #7

wants to merge 11 commits into from

Conversation

lehmann-4178656ch
Copy link
Member

No description provided.

@lehmann-4178656ch
Copy link
Member Author

lehmann-4178656ch commented May 21, 2024 •
edited
Loading

A test is failing but the could should be 80% there...

src/spatialjoin/tests/TestMain.cpp:143: Test failed!
  Expected static_cast<bool>(res.find("$freiburg1 contains Waldsee$") == std::string::npos) == 1, got 0

Please take a look, I try to work on this later again.

@lehmann-4178656ch lehmann-4178656ch force-pushed the convexhull branch 3 times, most recently from 7ffa053 to cd774fb Compare May 24, 2024 09:32
lehmann-4178656ch and others added 11 commits May 24, 2024 12:05
@lehmann-4178656ch
Convex hull
b064c5f
@lehmann-4178656ch
Rebase onto master and add changes
caed20f
@patrickbr @lehmann-4178656ch
only comp convex hull if needed, drop CH if no gain, dont use area of…
22aae95 
… full geom for CH comparisons, fix typo in point/CH comparison, only use CH if > 100 anchor points like other simplified polygons
@patrickbr @lehmann-4178656ch
parallel parsing, should be between 3x and 4x faster
419076f
@patrickbr @lehmann-4178656ch
dont run tests 10 mio times...
2725712
@lehmann-4178656ch
Convex hull
a798590
@patrickbr @lehmann-4178656ch
only comp convex hull if needed, drop CH if no gain, dont use area of…
f6a9f1b 
… full geom for CH comparisons, fix typo in point/CH comparison, only use CH if > 100 anchor points like other simplified polygons
@lehmann-4178656ch
Drop convex hull if same number of points and area as OBB
0bee150 
Rebase onto master
@lehmann-4178656ch
Explicitly check if obb is emtpy before cheking sizes.
19f54d9 
Drop convex hull if outer is has the same amount of points.
@lehmann-4178656ch
Remove some merge artifacts.
5adaa8f
@lehmann-4178656ch
Remove one more merge artifact.
b805dae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickbr patrickbr Awaiting requested review from patrickbr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lehmann-4178656ch @patrickbr