Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add windows wheels #46

Closed
wants to merge 5 commits into from

Conversation

plusiv
Copy link
Contributor

@plusiv plusiv commented Oct 23, 2023

Aims to fix #24 .

Currently cibuildwheel supports windows builds.

@plusiv plusiv changed the title Feat add windows wheels Feat: add windows wheels Oct 23, 2023
@plusiv plusiv marked this pull request as draft October 23, 2023 21:37
@Master-Hash

This comment has been minimized.

@anonrig
Copy link
Member

anonrig commented Oct 24, 2023

The problem is at the C/C++ library, I guess it cannot work well with msvc.

Ada supports MSVC 2019+ and used by Node.js and Cloudflare Workers at the moment. If you think there is a bug with Ada, please open an issue to the Ada repository.

@plusiv
Copy link
Contributor Author

plusiv commented Oct 24, 2023

The real problem seems to be that the object file ada.o is not being generated before wheel build, I need to specify that from the Makefile in the pyproject.toml file. Unfortunately I don't have my Windows machine with me right now to make some more tests locally before pushing more changes, and I don't want to waste the actions minutes.

I'm Going to push more changes tomorrow.

@Master-Hash
Copy link
Contributor

If you're occupied, I may try to fix it this evening(UTC+8). @plusiv

@plusiv
Copy link
Contributor Author

plusiv commented Oct 28, 2023

Closed due #47.
Thanks @Master-Hash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build wheels for Windows
3 participants