Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReFT generate & orthogonal fixes #778

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

ReFT generate & orthogonal fixes #778

wants to merge 4 commits into from

Conversation

calpt
Copy link
Member

@calpt calpt commented Jan 9, 2025

Resolves #772.

Provides the following fixes for the ReFT implementation:

  • support cases where seq_len < prefix/ suffix position (fixes issues with seq generation)
  • ensure orthogonal projection is always initialized with float32 (as half precision is not supported)

@calpt calpt mentioned this pull request Jan 9, 2025
Open
4 tasks
@calpt calpt marked this pull request as ready for review January 11, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoImhof TimoImhof Awaiting requested review from TimoImhof

@lenglaender lenglaender Awaiting requested review from lenglaender

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReFT does not support BFloat16
1 participant
@calpt