Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: aria-label class not properly hidden (fixes #606) #611

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix: aria-label class not properly hidden (fixes #606) #611

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9732761
Fix: aria-label class not properly hidden (fixes #606)
hanshillen Jan 7, 2025
06edfaf
Remove redundant display, add pointer-events
hanshillen Jan 7, 2025
7818c98
Addressed feedback
hanshillen Jan 17, 2025
21ed4f0
Update less/core/accessibility.less
hanshillen Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 16 additions & 21 deletions less/core/accessibility.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,33 +3,28 @@
.component { position: relative; }
.block { position: relative; }

oliverfoster marked this conversation as resolved.
Show resolved Hide resolved
// jquery.a11y start
// Invisible aria-labels
// --------------------------------------------------
.aria-label {
.aria-label, .visually-hidden {
display: block;
position: absolute !important;
&.relative {
position: relative !important;
}
left: 0 !important;
width: auto !important;
height: auto !important;
overflow: auto !important;
color: rgba(0,0,0,0) !important;
background: rgba(0,0,0,0) !important;
font-size: 1px !important;
width: 1px !important;
height: 1px !important;
padding: 0 !important;
margin: 0 !important;
line-height: normal !important;
z-index: 1;
margin: -1px !important;
overflow: hidden !important;
clip: rect(0, 0, 0, 0) !important;
white-space: nowrap !important;
border: 0 !important;
pointer-events: none;
}

oliverfoster marked this conversation as resolved.
Show resolved Hide resolved
// Force aria-labels to hide on hidden
// --------------------------------------------------
.aria-label.aria-hidden {
display: none !important;
.aria-label-focusable, .visually-hidden-focusable {
&:not(:focus):not(:focus-within) {
.visually-hidden
oliverfoster marked this conversation as resolved.
Show resolved Hide resolved
}
}

// jquery.a11y start

// Hidden focus guard
// --------------------------------------------------
.a11y-focusguard {
Expand Down