Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Removed select on focus behaviour allowed space and enter for selection #230

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix: Removed select on focus behaviour allowed space and enter for selection #230

wants to merge 4 commits into from

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Jan 16, 2025 •
edited
Loading

fixes #229

This should fix ios voiceover selection issues on radio (single select) mcqs and gmcqs

Reference: https://www.w3.org/WAI/ARIA/apg/patterns/radio/

Fix

  • Remove select on focus
  • Allow both space and enter to toggle
  • Deprecated onKeyPress for onKeyDown

@oliverfoster oliverfoster self-assigned this Jan 16, 2025
@swashbuck
Copy link

swashbuck commented Jan 16, 2025 •
edited
Loading

@oliverfoster The keyPress event is deprecated. Can you switch it to the keyDown event and rename the function?

adapt-contrib-mcq/templates/mcq.jsx

Line 72 in 13ca7d2

onKeyPress={onKeyPress}

swashbuck
swashbuck reviewed Jan 16, 2025
View reviewed changes
js/McqView.js Outdated Show resolved Hide resolved
swashbuck
swashbuck approved these changes Jan 16, 2025
View reviewed changes
Copy link

@swashbuck swashbuck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested iPhone 13 with VoiceOver iOS

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@swashbuck swashbuck swashbuck approved these changes

Assignees

@oliverfoster oliverfoster

Labels
accessibility bug
Projects
adapt_framework: The TODO Board
Status: Needs Reviewing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VoiceOver iOS: Moving focus automatically selects a radio
3 participants
@oliverfoster @swashbuck @cahirodoherty-learningpool