Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: ai update state_reader.py #99

Closed
wants to merge 1 commit into from
Closed

Conversation

rhizoome
Copy link

No description provided.

@rhizoome rhizoome force-pushed the jlf/state_reader.py branch from 72bda33 to 6a8c179 Compare March 22, 2024 17:28
@rhizoome rhizoome requested a review from winged March 22, 2024 17:52
Copy link
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just some minor thins I noticed

"""
Read all available system states.

This method sequentially reads the current system states for GPG keys,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This method sequentially reads the current system states for GPG keys,
This method reads the current system states for GPG keys,

Comment on lines +69 to +70
publish mappings by invoking the respective read methods for each
entity.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
publish mappings by invoking the respective read methods for each
entity.
publish mappings.

@winged
Copy link
Member

winged commented Jun 11, 2024

If needed we can still look at this. Closing. (JLF)

@winged winged closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants