adding optional override for player's launch url base

adlnet · May 22, 2024 · 7fffbb5 · 7fffbb5
1 parent b650497
commit 7fffbb5
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 11 deletions.
diff --git a/cts/.env.example b/cts/.env.example
@@ -2,7 +2,8 @@ HOSTNAME=localhost
 
 PLAYER_ROOT_PATH=/player
 PLAYER_BASE_URL=http://player:3398/player
-PLAYER_CONTENT_URL=http://localhost:3398/player/content
+PLAYER_CONTENT_URL=http://localhost/player/content
+PLAYER_LAUNCH_URL_BASE=http://localhost/player
 PLAYER_KEY=cts
 PLAYER_SECRET=player-secret
 PLAYER_TOKEN_SECRET=player-token-secret

diff --git a/player/.env.example b/player/.env.example
@@ -14,3 +14,4 @@ LRS_XAPI_VERSION=1.0.3
 
 ## Default is empty, add if necessary for nginx config
 PLAYER_API_ROOT=
+PLAYER_LAUNCH_URL_BASE=
diff --git a/player/service/package-lock.json b/player/service/package-lock.json
diff --git a/player/service/package.json b/player/service/package.json
@@ -42,12 +42,12 @@
     "libxmljs": "^0.19.8",
     "mysql": "^2.18.1",
     "node-stream-zip": "^1.13.6",
+    "uuid": "^9.0.1",
     "wait-port": "^0.2.9"
   },
   "devDependencies": {
     "chai": "^4",
     "dotenv": "^16.4.5",
-    "mocha": "^10.4.0",
-    "uuid": "^9.0.1"
+    "mocha": "^10.4.0"
   }
 }
diff --git a/player/service/plugins/routes/v1/courses.js b/player/service/plugins/routes/v1/courses.js
@@ -730,8 +730,6 @@ module.exports = {
                             moveOn = req.payload.moveOn || courseAu.metadata.moveOn || "NotApplicable",
                             alternateEntitlementKey = req.payload.alternateEntitlementKey || courseAu.metadata.alternateEntitlementKey,
 
-                            baseUrl = `${protocol}//${req.url.host}${rootPath}`,
-                            endpoint = `${baseUrl}/lrs`,
                             sessionId = uuidv4(),
                             contextTemplate = {
                                 contextActivities: {
@@ -746,6 +744,9 @@ module.exports = {
                                 }
                             };
 
+                        let launchURLBase = (process.env.PLAYER_LAUNCH_URL_BASE || `${protocol}//${req.url.host}${rootPath}`);
+                        let endpoint = `${launchURLBase}/lrs`;
+
                         // //Debug messages for troubleshooting host and path issuse - MB
                         // console.log("Base url is ", baseUrl);
                         // console.log("Which makes endpoint ", endpoint);
@@ -923,7 +924,7 @@ module.exports = {
                         const launchUrlParams = new URLSearchParams(
                             {
                                 endpoint,
-                                fetch: `${baseUrl}/fetch-url/${session.id}`,
+                                fetch: `${launchURLBase}/fetch-url/${session.id}`,
                                 actor: JSON.stringify(actor),
                                 activityId: lmsActivityId,
                                 registration: reg.code
Original file line number	Diff line number	Diff line change
Expand Up		@@ -14,3 +14,4 @@ LRS_XAPI_VERSION=1.0.3

		## Default is empty, add if necessary for nginx config
		PLAYER_API_ROOT=
		PLAYER_LAUNCH_URL_BASE=