Improve build pipeline summary publish link text with build failure warning

[andrew-m-leonard]

Fixes #1149

• Provide a "WARNING build result(FAILURE)" type message next to Publish binary link, to warn user the build job was not successful, and provide link to build job to check...
• Also fixed groovy script from bombing out if no .tap files exist

eg.https://ci.adoptium.net/job/build-scripts/job/release-openjdk17-pipeline/80/

[github-actions]

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

[andrew-m-leonard]

run tests

[sophia-guo]

Does this mean build job status set as unsuccessful due to test failures will also generate this warning link?

[eclipse-temurin-bot]

 PR TESTER RESULT 

✅ All pipelines passed! ✅

[andrew-m-leonard]

Does this mean build job status set as unsuccessful due to test failures will also generate this warning link?

if not SUCCESS|UNSTABLE, yes

[andrew-m-leonard]

@sxa @sophia-guo ready for review please

[andrew-m-leonard]

run tests

[eclipse-temurin-bot]

 PR TESTER RESULT 

✅ All pipelines passed! ✅

[sxa]

One comment, but pre-approving on the assumption that the answer to my question is "No" :-)

[sophia-guo]

Just a note that build failure or aborted could also be the child test jobs' failure or aborted. When this warning exists don't be too scared.

[sophia-guo]

I personally would prefer no link at all if the build jar itself is built unsuccessful. The main point is if the build jar built unsuccessful with the link it may be published by accident. So if no link enabled there will be no accident at all.

[sxa]

I personally would prefer no link at all if the build jar itself is built unsuccessful. The main point is if the build jar built unsuccessful with the link it may be published by accident. So if no link enabled there will be no accident at all.

Can you clarify what you mean by "build jar"? Are you describing a situation where the warning message would not be displayed? Or do you think the warning messages isn't obvious enough in general as it still lets you override it (which is the intention here)

[sophia-guo]

build jar --> jdk tarballs.

Are you describing a situation where the warning message would not be displayed?

I prefer if there are errors related with building the jdk tarball process there should not be the publish link at all.

[sxa]

I prefer if there are errors related with building the jdk tarball process there should not be the publish link at all.

@andrew-m-leonard What happens here if the build fails and doesn't produce a tarball? Will it still give a link (although it wouldn't work since it would fail to publish a tarball that didn't exist)?

(To be clear I don't think these questions should block this PR, but may be useful to be aware. We should perhaps add a note to the releasing guide about this 'new' functionality so it's clear what it means.)

[sophia-guo]

What happens here if the build fails and doesn't produce a tarball?

For release , no link will be given for this failed specific build(os-arch).