Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace file #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

replace file #3

wants to merge 1 commit into from

Conversation

shahawi
Copy link
Contributor

@shahawi shahawi commented Apr 24, 2019

replace file no need to remove harakat

replace file no need to remove harakat
@shahawi
Copy link
Contributor Author

shahawi commented Apr 24, 2019

The verses were copied from the same zip file containing the original csv file

@aelbuni
Copy link
Owner

aelbuni commented Apr 24, 2019

Thanks Shahawi for your continuous contribution.

For the Harakaat, although it is really hard to use them for topic modeling, but for research purposes, we should keep them, as the same word with different harakat can give meanings that we want to retain through exclusion (Check this line)

Apart from that, it will be nice to convert this code into a packaged OOP library eventually, let me know if you are interested to restructure the code into a cleaner OOP format.

@shahawi
Copy link
Contributor Author

shahawi commented Apr 24, 2019

Ok thanks understood,
Considering the OOP, I am an Android developer with very little experience in python and ML,
But I have free time and I love trying new things.
So if you can give me some pointers of what you want, I think I can help, after all java and python are both OOP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants