-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AYS-661 | Refactor email validation limits #431
base: main
Are you sure you want to change the base?
Changes from all commits
bdf4988
ff13feb
8445f18
06a5c25
6e5e703
3f71542
93d2655
6b82a40
ea6d6bf
bbc8fd2
42436ae
da7ef84
ebecffb
4bf17bc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -85,4 +85,4 @@ public void setInstitutionId(final String institutionId) { | |
.build(); | ||
} | ||
|
||
} | ||
} |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bu dosyayı geri alabilir miyiz? Formatı bozulmuş görünüyor. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bu dosya hâlâ eski hâline alınmamış gibi duruyor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pr actiktan veya yeni bir commit attiktan sonra sag ustten degisiklik yapilan satir sayisina goz atmak, istemedigimiz degisiklikler yapip yapmadigimiz konusunda bir fikir verip boyle durumlara karsi uyarabilir 🙌 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bu kisim hala ayni sekilde gorunuyor |
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Size kontrolu buradan kaldirilmis ancak
@EmailAddress
anotasyonu icerisine eklenmemis, o eklemeyi yapabilir miyiz?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Size kontrolünü'de @agitrubard isteği üzerine kaldırdım. Kontrol saten EmailAddress içinde yapılıyormuş. Ekstra bir şey eklememe gerek var mı yine de?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Onceki commitinde hem burada
@Size
anotasyonu eklenmis hem de@EmailAddress
anotasyonunun icerisine size kontrolu eklenmisti. Dolayisiyla@Size
anotasyonunu kaldirmak yeterli olacakti ancak sonraki committe ikisi birden kaldirilmis.@EmailAddress
anotasyonunun icerisine tekrar ekleme yapabilir misin?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tamamdır gözümden kaçmış affola.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hic onemli degil, yardimci olabildiysem ne mutlu bana 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emailaddress interface sınıfına hiç dokunmamıştım. Eğer commit mesajımla alakalı bahsetmişseniz ben orada emailAddress attribute'unun üstündeki anatasyon olarak belirtmek istedim. Eğer yanlışım varsa düzeltin çünkü commitlerimin hepsine baktım ama hiç ellememişim interface sınıfını.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EmailAddressValidator sınıfındaki bu değişiklikleri kastetmiştim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kusuruma bakmayın gözümden kaçmış şimdi düzelttim commit ettim.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rica ederim eline saglik 🙌🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bu kisim tekrar kaldirilmis gorunuyor