Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AYS-448 | Login Functionality Automation #48

Merged
merged 9 commits into from
Dec 22, 2024

Conversation

cagla88
Copy link
Collaborator

@cagla88 cagla88 commented Nov 8, 2024

Pull Request

Description:
Positive and negative scenarios have been added for login function.

Changes Made:
Login.feature edited and new scenarios have been added.
AysLocaleStorageUtil class added.
Localization Testing structure added.
RunnerForSmokeTest class edited.

Additional Information:
Add any additional information that might be relevant to reviewers.

Reviewer Instructions:
Provide instructions or guidelines for reviewers to follow when assessing your pull request.

Checklist

Before submitting your pull request, ensure the following:

  • Title and Branch Naming Conventions:

  • Local Testing:

    • I have added positive and negative test scenarios (if applicable)
    • All tests are passing.
    • I tagged all test as smoke or regression
    • I added newly added tests to related xml file in test suite
  • Code Quality:

    • The code is formatted according to the project's coding guidelines and style.
    • The code has been reviewed to ensure its quality.
    • The code does not contain any issues flagged by SonarLint.
  • Documentation:

    • Necessary documentation has been added or existing documentation has been updated.
  • Reviewers and Assignees:

    • Default reviewers have been assigned to this pull request.
    • Assignees have been added if necessary.
  • Labels and Associations:

    • No specific actions are required in the Labels and Associations section for this pull request.
  • Reviewer Instructions:

    • Provide instructions or guidelines for reviewers to follow when assessing your pull request.

@cagla88 cagla88 self-assigned this Nov 8, 2024
@cagla88 cagla88 marked this pull request as draft November 8, 2024 07:02
@cagla88 cagla88 marked this pull request as ready for review December 3, 2024 15:01
@cagla88
Copy link
Collaborator Author

cagla88 commented Dec 3, 2024

@agitrubard @Nbhtozcn @TekinMerve @htczrrsz selamlar, login testlerini tamamladım drafttan kaldırdım. Review yapabilir misiniz?

@cagla88 cagla88 requested a review from htczrrsz December 4, 2024 13:27
htczrrsz
htczrrsz previously approved these changes Dec 5, 2024
htczrrsz
htczrrsz previously approved these changes Dec 11, 2024
src/test/java/org/ays/step_definitions/Login.java Outdated Show resolved Hide resolved
src/test/java/org/ays/step_definitions/Login.java Outdated Show resolved Hide resolved
src/test/java/org/ays/step_definitions/Login.java Outdated Show resolved Hide resolved
src/test/java/org/ays/step_definitions/Login.java Outdated Show resolved Hide resolved
src/test/java/org/ays/utilities/AysLocaleStorageUtil.java Outdated Show resolved Hide resolved
src/test/java/org/ays/utilities/AysLocalizationUtil.java Outdated Show resolved Hide resolved
src/test/java/org/ays/utilities/AysLocalizationUtil.java Outdated Show resolved Hide resolved
src/test/resources/ays_ui_elements_tr.properties Outdated Show resolved Hide resolved
src/test/resources/ays_ui_elements_en.properties Outdated Show resolved Hide resolved
@cagla88 cagla88 requested a review from agitrubard December 20, 2024 14:39
agitrubard
agitrubard previously approved these changes Dec 21, 2024
@cagla88 cagla88 requested a review from htczrrsz December 22, 2024 11:10
@cagla88 cagla88 merged commit c6c1b4f into main Dec 22, 2024
1 check passed
@cagla88 cagla88 deleted the refactor/AYS-448/loginFunctionRefactoring branch December 22, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants