making TextMessage take a list[dict[str, str | dict[str, Any]]] as value because MultimodalConversableAgent was breaking while processing images. #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lues can be another nested dict representing image url, hence both str and dict should be allowed issue ag2ai#558
shriyanshagnihotri
force-pushed
the
main-bug-MultimodalConversableAgent-TextMessage-#558
branch
from
0fb862a to
caf8eba
Compare
shriyanshagnihotri
had a problem deploying
to
openai1
GitHub Actions
Failure
shriyanshagnihotri
had a problem deploying
to
openai1
GitHub Actions
Failure
shriyanshagnihotri
had a problem deploying
to
openai1
GitHub Actions
Failure
shriyanshagnihotri
had a problem deploying
to
openai1
GitHub Actions
Failure
shriyanshagnihotri
had a problem deploying
to
openai1
GitHub Actions
Failure
shriyanshagnihotri
had a problem deploying
to
openai1
GitHub Actions
Failure
|
The test is broken due to the new version of CrewAI, I'll fix it in a separate PR soon. This is good to go 👍 |
davorrunje
approved these changes
Jan 20, 2025
I have merged a PR for it :), #562 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
making TextMessage take a list[dict[str, str | dict[str, Any]]] as value because MultimodalConversableAgent was breaking while processing images.
Why are these changes needed?
making TextMessage take a list[dict[str, str | dict[str, Any]]] as value because MultimodalConversableAgent was breaking while processing images. Now with TextMessage taking dict with object value this should not breaking existing functionality of MultimodalConversableAgent
Related issue number
#558
Checks