Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty namespace from builder #1073

Merged

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Jan 10, 2025

Fix #1069

In principle the plugin's workchain should validate a input namespace is empty or not, but not all developers are doing this, see the xas issue: aiidateam/aiida-quantumespresso#1057

Here we remove the empty namespace for safety.

Edit: This change will affect all plugins, and we assume all empty namespaces are not used, which is by default when submitting a builder in the aiida-core.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.91%. Comparing base (75a792d) to head (a925b3d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1073      +/-   ##
==========================================
+ Coverage   67.90%   67.91%   +0.01%     
==========================================
  Files         113      113              
  Lines        6689     6689              
==========================================
+ Hits         4542     4543       +1     
+ Misses       2147     2146       -1     
Flag Coverage Δ
python-3.11 67.91% <100.00%> (+0.01%) ⬆️
python-3.9 67.93% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. LGTM!

@superstar54 superstar54 merged commit 416fb6f into aiidalab:main Jan 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XAS/XPS calculation: Application crashed with KeyError
2 participants