Fix verdi devel check-undesired-imports when tui extra is installed #6693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6693 +/- ##
==========================================
- Coverage 78.00% 77.99% -0.00%
==========================================
Files 563 563
Lines 41766 41769 +3
==========================================
Hits 32574 32574
- Misses 9192 9195 +3 ☔ View full report in Codecov by Sentry. |
danielhollas
force-pushed
the
check-undesired-imports-tui-fix
branch
from
1b1a850 to
eb1e91b
Compare
agoscinski
reviewed
Jan 16, 2025
| @@ -129,8 +129,6 @@ jobs: | |||
| with: | |||
| python-version: '3.12' | |||
| from-lock: 'true' | |||
| # NOTE: The `verdi devel check-undesired-imports` fails if | |||
| # the 'tui' extra is installed. | |||
| extras: '' | |||
There was a problem hiding this comment.
Should we include the extras here again? We just removed the extras because of the tui problem right?
There was a problem hiding this comment.
No, the extras were never included in this check, and I don't see why we should include them if they are not needed here.
agoscinski
requested changes
Jan 16, 2025
danielhollas
force-pushed
the
check-undesired-imports-tui-fix
branch
from
eb1e91b to
45c2d0a
Compare
danielhollas
force-pushed
the
check-undesired-imports-tui-fix
branch
from
45c2d0a to
ae9b298
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6691.
To test the fix run
This will fail on main with