Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cli options for config file management #33

Merged
merged 16 commits into from
Apr 1, 2020
Merged

add cli options for config file management #33

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
dee08d5
add cli options for config file management
ltalirz Mar 18, 2020
0a02ce2
add tests for new cli options
ltalirz Mar 29, 2020
7773cb9
try fixing docs
ltalirz Mar 30, 2020
b2460b0
Merge branch 'develop' into fix-args
ltalirz Mar 30, 2020
529fdf0
add import comment
ltalirz Mar 30, 2020
d32ed3c
add test for regeneration of test data
ltalirz Mar 30, 2020
06f60d5
try fixing github actions
ltalirz Mar 30, 2020
a8f7060
make sure to data directory exists
ltalirz Mar 31, 2020
be72c0a
add quotation marks to export strings
ltalirz Mar 31, 2020
d3c60ec
add sanity check
ltalirz Mar 31, 2020
2cfb86a
require path to be absolute
ltalirz Mar 31, 2020
9945558
Merge branch 'develop' into fix-args
ltalirz Mar 31, 2020
02d36fd
update docs
ltalirz Mar 31, 2020
4aa5c3e
remove sanity check again...
ltalirz Mar 31, 2020
0b704be
address suggestions by @greschd
ltalirz Apr 1, 2020
926fb93
add docs
ltalirz Apr 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions aiida_testing/mock_code/_fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,10 @@ def _get_mock_code(
# can not be reused.
code_label = f'mock-{label}-{uuid.uuid4()}'

data_dir_abspath = pathlib.Path(data_dir_abspath).absolute()
ltalirz marked this conversation as resolved.
Show resolved Hide resolved
if not data_dir_abspath.exists():
raise ValueError("Data directory '{}' does not exist".format(data_dir_abspath))

mock_executable_path = shutil.which('aiida-mock-code')
if not mock_executable_path:
raise ValueError(
Expand Down
3 changes: 3 additions & 0 deletions tests/mock_code/test_diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ def test_basic(mock_code_factory, generate_diff_inputs): # pylint: disable=rede
res, node = run_get_node(
CalculationFactory(CALC_ENTRY_POINT), code=mock_code, **generate_diff_inputs()
)
assert node.exit_status == 0, "diff calculation failed with exit status {}".format(
node.exit_status
)
assert node.is_finished_ok
check_diff_output(res)

Expand Down