Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog post for improvements to data access #72

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Conversation

GeigerJ2
Copy link
Contributor

@GeigerJ2 GeigerJ2 commented Sep 17, 2024

Meaning the process dumping feature and the more intuitive QB syntax.

EDIT: This should be ready for a first round of review. Thanks to @agoscinski's wisdom, I just changed the base of this PR to the branch of PR #69 on which it depends, so only the actual changes are shown. Requested review from @edan-bainglass as the author of the new QB syntax.

Direct link to the rendered version on RTD.

@GeigerJ2 GeigerJ2 mentioned this pull request Sep 17, 2024
@GeigerJ2 GeigerJ2 changed the base branch from main to feature/simpler-installation September 17, 2024 10:07
Copy link
Contributor

@agoscinski agoscinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can zoom into the terminal and use a high contrast mode? It is quite hard to see what is happening in the terminal.

This is not rendered properly
Screenshot 2024-09-17 at 15 42 04

create_post.py Show resolved Hide resolved
docs/news/posts/2024-10-04-data-access.md Show resolved Hide resolved
docs/news/posts/2024-10-04-data-access.md Show resolved Hide resolved
docs/news/posts/2024-10-04-data-access.md Outdated Show resolved Hide resolved
docs/news/posts/2024-10-04-data-access.md Outdated Show resolved Hide resolved
docs/news/posts/2024-10-04-data-access.md Outdated Show resolved Hide resolved
docs/news/posts/2024-10-04-data-access.md Show resolved Hide resolved
Copy link
Contributor

@agoscinski agoscinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request changes

@GeigerJ2 GeigerJ2 force-pushed the feature/simpler-installation branch from b73da39 to b7613a3 Compare September 19, 2024 05:20
@GeigerJ2
Copy link
Contributor Author

Maybe you can zoom into the terminal and use a high contrast mode? It is quite hard to see what is happening in the terminal.

Yeah, just like in presentations, terminal with white background might actually be preferable here (despite the eyeball cancer :D)

This is not rendered properly

Hm, weird, locally it aligns nicely. I'll investigate!

agoscinski
agoscinski previously approved these changes Sep 19, 2024
Copy link
Contributor

@agoscinski agoscinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the calculation-dump*gif used somewhere? Can you remove them if not used before merging

Base automatically changed from feature/simpler-installation to main September 20, 2024 05:15
@GeigerJ2 GeigerJ2 dismissed agoscinski’s stale review September 20, 2024 05:15

The base branch was changed.

An error occurred while trying to automatically change base from feature/simpler-installation to main September 20, 2024 05:15
edan-bainglass
edan-bainglass previously approved these changes Sep 23, 2024
Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, at least w.r.t new QueryBuilder syntax section. Thanks :)

@GeigerJ2
Copy link
Contributor Author

GeigerJ2 commented Sep 26, 2024

OK, I just applied the remaining changes and squashed the ~40 commits to clean up a bit, so this is ready for a final review, @agoscinski, @edan-bainglass, @giovannipizzi.

Direct link to rendered version on RTD

Copy link
Member

@giovannipizzi giovannipizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, and suggestions to slightly simplify some sentences

docs/news/posts/2024-10-04-data-access.md Outdated Show resolved Hide resolved
docs/news/posts/2024-10-04-data-access.md Outdated Show resolved Hide resolved
docs/news/posts/2024-10-04-data-access.md Outdated Show resolved Hide resolved
docs/news/posts/2024-10-04-data-access.md Outdated Show resolved Hide resolved
docs/news/posts/2024-10-04-data-access.md Outdated Show resolved Hide resolved
docs/news/posts/2024-10-04-data-access.md Outdated Show resolved Hide resolved
docs/news/posts/2024-10-04-data-access.md Outdated Show resolved Hide resolved
docs/news/posts/2024-10-04-data-access.md Outdated Show resolved Hide resolved
docs/news/posts/2024-10-04-data-access.md Show resolved Hide resolved
docs/news/posts/2024-10-04-data-access.md Outdated Show resolved Hide resolved
edan-bainglass
edan-bainglass previously approved these changes Oct 2, 2024
Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once Giovanni's comments are addressed, this is good to go from my end.

Copy link
Contributor Author

@GeigerJ2 GeigerJ2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks for the review, @giovannipizzi. I have implemented all of your suggested changes, and further improved the text.

docs/news/posts/2024-10-04-data-access.md Outdated Show resolved Hide resolved
docs/news/posts/2024-10-04-data-access.md Outdated Show resolved Hide resolved
docs/news/posts/2024-10-04-data-access.md Outdated Show resolved Hide resolved
docs/news/posts/2024-10-04-data-access.md Outdated Show resolved Hide resolved
docs/news/posts/2024-10-04-data-access.md Show resolved Hide resolved
docs/news/posts/2024-10-04-data-access.md Outdated Show resolved Hide resolved
@GeigerJ2
Copy link
Contributor Author

GeigerJ2 commented Oct 2, 2024

@khsrali linkcheck failing on some scientific URLs?

@khsrali
Copy link
Contributor

khsrali commented Oct 2, 2024

I checked the failing url manually:
https://journals.aps.org/prb/abstract/10.1103/PhysRevB.102.024106

And it works.
Most be some sort of blocking problem from GitHub client 🤔

@agoscinski
Copy link
Contributor

Maybe this works
sphinx-doc/sphinx#10343 (comment)

Would put it in ignore if this does not work, one can use also the doi instead, that should never fail anyway

@GeigerJ2
Copy link
Contributor Author

GeigerJ2 commented Oct 3, 2024

EDIT: Now, all links (apart from https://www.go-fair.org) are working again. Seemed to really have been some general outage...

@khsrali I'm just a bit confused because I guess it was working before. @agoscinski, good idea, I replaced it with the DOIs.

I also removed the go-fair.org link, because that website seems to be currently down. It was used in a 4-year-old post about Materials Cloud Archive, so I suppose that should be fine. Though, now https://www.max-centre.eu and https://www.intersect-project.eu also don't work (neither in my browser), so maybe there is currently another CloudFlare-like situation and websites are down 😅

@GeigerJ2 GeigerJ2 merged commit f5b1daa into main Oct 4, 2024
3 checks passed
@GeigerJ2 GeigerJ2 deleted the blog/data-access branch October 4, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants