-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict methods #543
base: master
Are you sure you want to change the base?
Restrict methods #543
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #543 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 475 487 +12
Branches 17 18 +1
=========================================
+ Hits 475 487 +12 ☔ View full report in Codecov by Sentry. |
I think that's overkill, we only want to ensure that the user understands that GET is the only allowed method for browsers. A boolean should suffice. |
Switched to bool |
I've added changelog as we don't seem to have any docs. I think that's fine, so feel free to merge if you're happy with it. |
@Dreamsorcerer, thanks I got some thoughts :D This way we helped to warn frontend developer with 405 status code after request. |
I would expect a backend developer to test their code, even if only with Postman or similar, which is why this probably still works. |
What do these changes do?
Are there changes in behavior for the user?
Related issue number
Checklist