fix the fix

aiortc · Jan 6, 2024 · 142ebe2 · 142ebe2
1 parent 6157d97
commit 142ebe2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/aioquic/quic/stream.py b/src/aioquic/quic/stream.py
@@ -207,8 +207,6 @@ def get_frame(
             if self._pending_eof:
                 # FIN only
                 self._pending_eof = False
-                if self._buffer_start == self._buffer_fin:
-                    self.is_finished = True
                 return QuicStreamFrame(fin=True, offset=self._buffer_fin)
 
             self.buffer_is_empty = True

diff --git a/tests/test_stream.py b/tests/test_stream.py
@@ -651,11 +651,15 @@ def test_sender_fin_then_ack(self):
         stream.sender.on_data_delivery(QuicDeliveryState.ACKED, 0, 4)
         self.assertFalse(stream.sender.is_finished)
 
-        # sending FIN transitions to finished
+        # send EOF
         frame = stream.sender.get_frame(8)
         self.assertEqual(frame.data, b"")
         self.assertTrue(frame.fin)
         self.assertEqual(frame.offset, 4)
+        self.assertFalse(stream.sender.is_finished)
+
+        # receive acknowledgement for EOF
+        stream.sender.on_data_delivery(QuicDeliveryState.ACKED, 4, 4)
         self.assertTrue(stream.sender.is_finished)
 
     def test_sender_fin_only_despite_blocked(self):