Implement address validation token for future connections for client #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 4672 4680 +8
=========================================
+ Hits 4672 4680 +8 ☔ View full report in Codecov by Sentry. |
jlaine
reviewed
Nov 16, 2023
src/aioquic/quic/connection.py
Outdated
| @@ -240,6 +251,7 @@ def __init__( | |||
| retry_source_connection_id: Optional[bytes] = None, | |||
| session_ticket_fetcher: Optional[tls.SessionTicketFetcher] = None, | |||
| session_ticket_handler: Optional[tls.SessionTicketHandler] = None, | |||
| token_handler: Optional[Callable] = None, | |||
There was a problem hiding this comment.
Can we do better than Callable here, as in define a tighter type for the function?
jlaine
force-pushed
the
patch-4
branch
2 times, most recently
from
20dbe61 to
a12f9ec
Compare
- Add `token` to `QuicConfiguration`. - Add `token_handler` to `aioquic.asyncio.connect`. See: https://www.rfc-editor.org/rfc/rfc9000.html#name-address-validation-for-futu Co-authored-by: Jeremy Lainé <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rfc-editor.org/rfc/rfc9000.html#name-address-validation-for-futu