Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise RSA key size for retry token generator / validator #409

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

jlaine
Copy link
Contributor

@jlaine jlaine commented Nov 4, 2023

A 1024-bit key cannot be considered secure, so raise this to 2048 bits.

Fixes: #407

A 1024-bit key cannot be considered secure, so raise this to 2048 bits.

Fixes: aiortc#407
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2fe490a) 100.00% compared to head (e6da64b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #409   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         4554      4554           
=========================================
  Hits          4554      4554           
Files Coverage Δ
src/aioquic/quic/retry.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlaine jlaine merged commit d9ee663 into aiortc:main Nov 4, 2023
24 checks passed
@jlaine jlaine deleted the retry-token-key-size branch November 4, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cryptographic API Misuse Vulnerability: Do not use Inadequate key length
1 participant