Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close connection if client's first INITIAL contains no CRYPTO #426

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

jlaine
Copy link
Contributor

@jlaine jlaine commented Dec 12, 2023

According to section 17.2.2 of RFC 9000, the client's first INITIAL packet must contain a CRYPTO frame. Ensure this is indeed to case to avoid connections in a half-connected state.

According to section 17.2.2 of RFC 9000, the client's first INITIAL
packet must contain a CRYPTO frame. Ensure this is indeed to case to
avoid connections in a half-connected state.
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6a6983) 100.00% compared to head (2ece55c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #426   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         4666      4673    +7     
=========================================
+ Hits          4666      4673    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlaine jlaine merged commit cd666b3 into aiortc:main Dec 12, 2023
29 checks passed
@jlaine jlaine deleted the initial-without-crypto branch December 12, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant