[h3] Adapt datagram API for RFC 9297 (fixes: #420) #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaine
changed the title
DatagramReceived event for RFC 9297 (fixes: #420)
jlaine
force-pushed
the
h3-datagram-rfc-9297
branch
from
ed93ea0 to
d993b04
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 4687 4691 +4
=========================================
+ Hits 4687 4691 +4 ☔ View full report in Codecov by Sentry. |
jlaine
force-pushed
the
h3-datagram-rfc-9297
branch
3 times, most recently
from
c55b9a9 to
56cd6fe
Compare
Our HTTP/3 code dealing with datagrams dates back to before RFC 9297 was published. This is reflected in the the use of the `flow_id` terminology which no longer exists. Update the following interfaces: - `DatagramReceived` now has a `stream_id` attribute instead of `flow_id`. - `H3Connection.send_datagram` now has a `stream_id` argument instead of `flow_id` Encoding and decoding to / from quarter stream ID is handled by the connection, so the user does not need to multiply or divide by four.
jlaine
force-pushed
the
h3-datagram-rfc-9297
branch
from
56cd6fe to
b7d98a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our HTTP/3 code dealing with datagrams dates back to before RFC 9297 was published. This is reflected in the the use of the
flow_idterminology which no longer exists. Update the following interfaces:h3.DatagramReceivednow has astream_idattribute instead offlow_idh3.Connection.send_datagramnow has astream_idargument instead offlow_idEncoding and decoding to / from quarter stream ID is handled by the connection, so the user does not need to multiply or divide by four.