Raise a TLS alert if parsing a message causes a BufferReadError #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 4864 4868 +4
=========================================
+ Hits 4864 4868 +4 ☔ View full report in Codecov by Sentry. |
|
If aioquic/src/aioquic/quic/connection.py Line 1588 in 5772246 |
While parsing TLS messages, if a `BufferReadError` occurs, it is a sign we are unable to parse the message because it is malformed. In such an event raise a `AlertDecodeError` exception so that the connection gets shut down with a TLS error.
jlaine
force-pushed
the
tls-decode-error
branch
from
1be1bdf to
9616e13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While parsing TLS messages, if a
BufferReadErroroccurs, it is a sign we are unable to parse the message because it is malformed. In such an event raise aAlertDecodeErrorexception so that the connection gets shut down with a TLS error.