Explicitly track whether FIN has been acknowledged #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 4864 4872 +8
=========================================
+ Hits 4864 4872 +8 ☔ View full report in Codecov by Sentry. |
jlaine
changed the title
|
@mhils Could you confirm this fixes the issue you encountered? I have naturally added you as a co-author! |
jlaine
force-pushed
the
stream-fin-fix
branch
2 times, most recently
from
98e7bd0 to
84d4d48
Compare
jlaine
changed the title
A stream's sender part is only finished if all the data and the FIN have been acknowledged. Tracking the acknowledged data ranges is not sufficient to know whether the FIN has been acknowledged too, as the FIN may have been sent on its own. To fix this we need to explicitly keep track of whether the frame containing the FIN was acknowledged. We also: - Remove a bogus assignment of `QuicStreamSender.send_buffer_empty`, this should have been `QuicStreamSender.buffer_is_empty`. - Only set `buffer_is_empty` to `False` when data or a FIN have been lost. This saves useless calls to `QuicStreamSender.get_frame()`. Co-authored-by: Maximilian Hils <[email protected]>
|
This looks fantastic, thanks so much! 😃 🍰 |
Cool! This is available from PyPI in version 0.9.25 😃 |
|
Oh also, this made me dig a little deeper and I found a potential issue related to RESET, fixed in #444 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A stream's sender part is only finished if all the data and the FIN have been acknowledged. Tracking the acknowledged data ranges is not sufficient to know whether the FIN has been acknowledged too, as the FIN may have been sent on its own. To fix this we need to explicitly keep track of whether the frame containing the FIN was acknowledged.
We also:
QuicStreamSender.send_buffer_empty, this should have beenQuicStreamSender.buffer_is_empty.buffer_is_emptytoFalsewhen data or a FIN have been lost. This saves useless calls toQuicStreamSender.get_frame().This is an alternative to #439